labels in submit buttons + new screenshot #4096
Conversation
|
I love it. Great job! |
This PR was merged into the 2.3 branch. Discussion ---------- labels in submit buttons + new screenshot | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #3983 As per @weaverryan suggestion in #3983 discussion PR is made against 2.3 branch since this is when submit buttons were added Commits ------- 261f6b2 labels in submit buttons + new screenshot
|
Thanks for merging @weaverryan I am checking the symfony docs webpage and I am able to see my changes in the examples but not the new image. Is this happening because it uses master or is it a different process or what? |
|
@ricardclau You can see it in the documentation for 2.3. @weaverryan didn't merge 2.3 into 2.4 and so on after your change. But he does this frequently. So, sooner or later your change will be in master too. |
|
@xabbuh When I added the comment to this PR the new image was not being displayed yet in the 2.3 docs but the code changes were. Maybe this is due to some CDN / Reverse proxy cache issue or something similar? And this is why I asked if the images may be following a different process Anyway, glad to see it there, thanks guys :) |
|
@ricardclau thanks for your pull request. It's nice to have you back here :) |
|
@ricardclau I misunderstood your question then. So yeah, I guess it's cache-related. |
As per @weaverryan suggestion in #3983 discussion
PR is made against 2.3 branch since this is when submit buttons were added